Add format number with thousands separator and no decimal #4444
Conversation
Add format number with thousands separator and no decimal "#,##0'"
| @@ -16,6 +16,7 @@ class NumberFormat extends Supervisor | |||
| const FORMAT_NUMBER_00 = '0.00'; | |||
| const FORMAT_NUMBER_COMMA_SEPARATED1 = '#,##0.00'; | |||
| const FORMAT_NUMBER_COMMA_SEPARATED2 = '#,##0.00_-'; | |||
| const FORMAT_NUMBER_COMMA_SEPARATED3 = '#,##0'; | |||
There was a problem hiding this comment.
Please use a more descriptive name for the constant, e.g. FORMAT_NUMBER_COMMA_SEPARATED_INTEGER.
|
Please add formal unit test(s) to show that your new constant works correctly. |
|
3 months, no update, closing. |
|
I'm not a coder so no idee how to do tests. Thanks. |
|
Wouldn't it be better if you told me that when I asked instead of just ignoring my request? Feel free to open a new PR if you wish. Your test should actually be pretty easy. Take a look at tests/data/NumberFormat.php. It has entries like: [
' $ 1,111.11 ',
'1111.111',
NumberFormat::FORMAT_ACCOUNTING_USD,
],The second line is the expected result of the formatting, the next line is the value which is to be formatted, and the next line is the format which is to be used. Add an entry to this file using your new constant. Be aware of my comment above that a more descriptive name is needed for the constant. |
Add format number with thousands separator and no decimal "#,##0'"
This is:
Why this change is needed?
Because I can't format a number wihtout decimal places.
Fixes Github #4443